[#SHALE-275] DialogNavigtionHandler breaks the implicit Decorator pattern

Shale

DialogNavigtionHandler breaks the implicit Decorator pattern

Created: 04/Sep/06 11:45 PM Updated: 23/Jan/07 04:40 PM

Return to search

Component/s:

Dialog, Sandbox

Affects Version/s:

1.0.3

Fix Version/s:

1.0.4

Issue Links:

Reference

This issue is related to:

~~SHALE-10~~ [shale] IFrame does not work properly inside Shale dialog

Description

« Hide

Because DialogNavigationHandler makes use of the Decorator pattern, it is strongly implied that navigation outcomes that are not handled by it will be delegated to the wrapped instance of NavigationHandler. This is not happening in the current nightly code for dialog (nor is it happening in the sandbox rewrite.)

All

Comments

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

sean schofield added a comment - 04/Sep/06 11:46 PM

This issue relates somewhat to ~~SHALE-10~~. Once addressed we should revisit that issue and see if there are any remaining problems.

sean schofield made changes - 04/Sep/06 11:46 PM

Field	Original Value	New Value
Link		This issue is related to ~~SHALE-10~~ [ ~~SHALE-10~~ ]

[ Permlink | « Hide ]

sean schofield added a comment - 04/Sep/06 11:47 PM

I have created a test case that verifies the problem and solution. Test case introduces a shale-test and jmock dependency but this is just for testing so I think we're fine with this result.

sean schofield made changes - 04/Sep/06 11:47 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#440205	Mon Sep 04 23:52:55 UTC 2006	schof	Fixed a bug where navigation outcomes that were unrelated to the current dialog were being ignored. They're now delegated to the wrapped NavigationHandler. ~~SHALE-275~~
				Files Changed
				ADD /shale/sandbox/shale-dialog2/src/test/java/org/apache ADD /shale/sandbox/shale-dialog2/src/test/java/org/apache/shale/dialog2 MODIFY /shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/faces/Dialog2NavigationHandler.java ADD /shale/sandbox/shale-dialog2/src/test/java/org/apache/shale MODIFY /shale/sandbox/shale-dialog2/pom.xml ADD /shale/sandbox/shale-dialog2/src/test/java/org/apache/shale/dialog2/faces ADD /shale/sandbox/shale-dialog2/src/test/java/org ADD /shale/sandbox/shale-dialog2/src/test/java/org/apache/shale/dialog2/faces/Dialog2NavigationHandlerTest.java

Rahul Akolkar made changes - 23/Jan/07 04:40 PM

Fix Version/s		1.0.4 [ 21790 ]
Fix Version/s	1.0.4-SNAPSHOT [ 21740 ]

Jeff Turner made changes - 09/Aug/07 07:17 AM

Workflow

Struts [ 38707 ]

Struts - editable closed status [ 42372 ]

Antonio Petrelli made changes - 08/Jan/09 08:56 AM

Workflow

Struts - editable closed status [ 42372 ]

Struts - editable closed status (temporary) [ 45977 ]

Antonio Petrelli made changes - 08/Jan/09 09:08 AM

Workflow

Struts - editable closed status (temporary) [ 45977 ]

Struts - editable closed status [ 52674 ]