[#SHALE-271] Dialog2 can't find my dialog definitions

Shale

Dialog2 can't find my dialog definitions

Created: 03/Sep/06 06:06 PM Updated: 23/Jan/07 04:40 PM

Return to search

Component/s:

Sandbox

Affects Version/s:

None

Fix Version/s:

1.0.4

Description

« Hide

Apparently the dialog stuff is unable to find my dialog definition. I have it in WEB-INF/dialog-config.xml so I will investigate and see what the issue is.

All

Comments

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Craig McClanahan added a comment - 03/Sep/06 11:35 PM

This should be fixed now in the latest trunk code (we're not publishing nightly builds of the sandbox stuff). The "shale-test-dialog2-legacy" webapp in the sandbox illustrates that this works, because it now comments out the name of the default resource that is loaded automatically.

Craig McClanahan made changes - 03/Sep/06 11:35 PM

Field	Original Value	New Value
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#439874	Sun Sep 03 23:37:16 UTC 2006	craigmcc	Update legacy configuration resource parsing to automatically parse the default resource (/WEB-INF/dialog-config.xml), if it exists, even if it was not explicitly called out in a context init parameter. ~~SHALE-271~~
				Files Changed
				MODIFY /shale/sandbox/shale-dialog2-legacy/src/main/java/org/apache/shale/dialog2/legacy/LegacyDialogManager.java MODIFY /shale/sandbox/shale-test-dialog2-legacy/src/main/webapp/WEB-INF/web.xml

Repository	Revision	Date	User	Message
ASF	#439876	Sun Sep 03 23:51:39 UTC 2006	schof	Added a WARN message when no dialog configuration information is found. (~~SHALE-271~~)
				Files Changed
				MODIFY /shale/sandbox/shale-dialog2-legacy/src/main/java/org/apache/shale/dialog2/legacy/LegacyDialogManager.java

Repository	Revision	Date	User	Message
ASF	#439881	Mon Sep 04 00:07:14 UTC 2006	craigmcc	After a quick chat with Sean about our dueling commits, we agreed that not warning is the appropriate behavior, so I commented that out. Not having any config parameter, but providing an instance of the default resource (/WEB-INF/dialog-config.xml) is a nice standard behavior, and mirrors how JSF handles faces-config.xml resources. I left in the Log variable (because we're likely to want it later), but adjusted the implementation to reflect recent "best practices" advice from the Commons Logging docs: * Static Log instances can cause webapp unload problems on some containers, so make it an instance variable. * Because we are inside a Serializable object, we need to declare the Log instance transient since there is no guarantee that such instances are themselves Serializable. * The previous change means we need to be able to re-create the instance on demand if needed. That is done by a new private Log log() method implementation, which should be called by any code that actually wants to log something. We need to review this kind of thing all the way throughout Shale at some point. ~~SHALE-271~~
				Files Changed
				MODIFY /shale/sandbox/shale-dialog2-legacy/src/main/java/org/apache/shale/dialog2/legacy/LegacyDialogManager.java

Rahul Akolkar made changes - 23/Jan/07 04:40 PM

Fix Version/s		1.0.4 [ 21790 ]
Fix Version/s	1.0.4-SNAPSHOT [ 21740 ]

Jeff Turner made changes - 09/Aug/07 07:15 AM

Workflow

Struts [ 38703 ]

Struts - editable closed status [ 41664 ]

Antonio Petrelli made changes - 08/Jan/09 08:56 AM

Workflow

Struts - editable closed status [ 41664 ]

Struts - editable closed status (temporary) [ 45907 ]

Antonio Petrelli made changes - 08/Jan/09 09:08 AM

Workflow

Struts - editable closed status (temporary) [ 45907 ]

Struts - editable closed status [ 53029 ]