
|
If you were logged in you would be able to see more operations.
|
|
|
|
Apparently the dialog stuff is unable to find my dialog definition. I have it in WEB-INF/dialog-config.xml so I will investigate and see what the issue is.
|
|
Description
|
Apparently the dialog stuff is unable to find my dialog definition. I have it in WEB-INF/dialog-config.xml so I will investigate and see what the issue is. |
Show » |
| Repository |
Revision |
Date |
User |
Message |
| ASF |
#439881 |
Mon Sep 04 00:07:14 UTC 2006 |
craigmcc |
After a quick chat with Sean about our dueling commits, we agreed that
*not* warning is the appropriate behavior, so I commented that out.
Not having any config parameter, but providing an instance of the
default resource (/WEB-INF/dialog-config.xml) is a nice standard
behavior, and mirrors how JSF handles faces-config.xml resources.
I left in the Log variable (because we're likely to want it later), but
adjusted the implementation to reflect recent "best practices" advice
from the Commons Logging docs:
* Static Log instances can cause webapp unload problems
on some containers, so make it an instance variable.
* Because we are inside a Serializable object, we need to
declare the Log instance transient since there is no
guarantee that such instances are themselves Serializable.
* The previous change means we need to be able to re-create
the instance on demand if needed. That is done by a new
private Log log() method implementation, which should be
called by any code that actually wants to log something.
We need to review this kind of thing all the way throughout Shale at
some point.
SHALE-271
|
| Files Changed |
MODIFY
/shale/sandbox/shale-dialog2-legacy/src/main/java/org/apache/shale/dialog2/legacy/LegacyDialogManager.java
|
|