Issue Details (XML | Word | Printable)

Key: SHALE-270
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: alberto
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Shale

Illegal date format

Created: 01/Sep/06 04:39 PM   Updated: 23/Jan/07 04:40 PM
Return to search
Component/s: Remoting
Affects Version/s: 1.0.4-SNAPSHOT
Fix Version/s: 1.0.4

Environment: JSF 1.2, Glassfish.


 Description  « Hide
I am serving my javascript resource with shale-remoting.
When the resorce enters in client cache, and the browser try to validate a cache entry I get this exception:

phase(RESTORE_VIEW 1,com.sun.faces.context.FacesContextImpl@1a6af53) threw exception: java.lang.IllegalArgumentException: ven, 01 set 2006 16:00:23 GMT ven, 01 set 2006 16:00:23 GMT
org.apache.coyote.tomcat5.CoyoteRequest.getDateHeader(CoyoteRequest.java:2104)
org.apache.coyote.tomcat5.CoyoteRequestFacade.getDateHeader(CoyoteRequestFacade.java:652)
javax.servlet.http.HttpServletRequestWrapper.getDateHeader(HttpServletRequestWrapper.java:83)
org.apache.shale.remoting.impl.AbstractResourceProcessor.ifModifiedSince(AbstractResourceProcessor.java:349)
org.apache.shale.remoting.impl.AbstractResourceProcessor.process(AbstractResourceProcessor.java:101)
org.apache.shale.remoting.faces.RemotingPhaseListener.afterPhase(RemotingPhaseListener.java:102)
...

You can see that "ven, 01 set 2006 16:00:23 GMT ven, 01 set 2006 16:00:23 GMT" is an italian date format.
I use FireFox, but I think FF is not the problem.
What I believe is that Shale is sending the "Last-Modified" date in an italian format (I am italian).

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #473628 Sat Nov 11 02:09:30 UTC 2006 craigmcc SHALE-270 Ensure that the timestamp generated for HTTP headers always uses
the US spellings of the day and month abbreviations, as required by the
HTTP spec. Thanks to Ryan Lubke for pointing out the fix.
Files Changed
MODIFY /shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/impl/AbstractResourceProcessor.java

Craig McClanahan added a comment - 11/Nov/06 02:10 AM
Fixed by configuring the SimpleDateFormat instance used for creating HTTP header timestamps to use the US locale, and therefore pick up the required spellings. Thanks to Ryan Lubke for pointing out the appropriate fix.

Fixed in nightly build 20061111. Will be included in 1.0.4 also.

Craig McClanahan made changes - 11/Nov/06 02:10 AM
Field Original Value New Value
Resolution Fixed [ 1 ]
Fix Version/s 1.0.4-SNAPSHOT [ 21740 ]
Status Open [ 1 ] Resolved [ 5 ]
Rahul Akolkar made changes - 23/Jan/07 04:40 PM
Fix Version/s 1.0.4-SNAPSHOT [ 21740 ]
Fix Version/s 1.0.4 [ 21790 ]
Jeff Turner made changes - 09/Aug/07 07:17 AM
Workflow Struts [ 38699 ] Struts - editable closed status [ 42410 ]
Antonio Petrelli made changes - 08/Jan/09 08:57 AM
Workflow Struts - editable closed status [ 42410 ] Struts - editable closed status (temporary) [ 46307 ]
Antonio Petrelli made changes - 08/Jan/09 09:08 AM
Workflow Struts - editable closed status (temporary) [ 46307 ] Struts - editable closed status [ 52940 ]