Issue Details (XML | Word | Printable)

Key: SHALE-256
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Craig McClanahan
Reporter: Craig McClanahan
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Shale

Cannot use annotated managed beans unless ShaleApplicationFilter is configured

Created: 19/Aug/06 12:49 AM   Updated: 21/Aug/06 11:28 PM
Return to search
Component/s: Tiger
Affects Version/s: None
Fix Version/s: 1.0.3


 Description  « Hide
Currently, class org.apache.shale.tiger.faces.LifecycleListener (which, among other things, processes the managed beans configuration information needed for annotated managed beans) is only triggered if ShaleApplicationFilter is configured. It should be possible to use annotated managed beans even if the filter is *not* configured.


 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Craig McClanahan made changes - 19/Aug/06 12:49 AM
Field Original Value New Value
Assignee Craig McClanahan [ craigmcc ]
Repository Revision Date User Message
ASF #432781 Sat Aug 19 02:12:09 UTC 2006 craigmcc Refactor the logic that was in
org.apache.shale.tiger.faces.LifecycleListener into class
org.apache.shale.tiger.view.faces.LifecycleListener2 instead. Besides
reducing the two similar-focused classes into one, this also enables the
use of annotated managed beans even if the Shale Application Filter is
not configured.

Leaving the relevant issue (SHALE-256) open until a system integration
test is added to catch any future regressions on this functionality.
Files Changed
DEL /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/LifecycleListenerTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-test-tiger/src/main/java/org/apache/shale/examples/test/tiger/ApplicationBean.java
MODIFY /shale/framework/trunk/shale-apps/shale-test-tiger/src/main/java/org/apache/shale/examples/test/tiger/Managed.java
MODIFY /shale/framework/trunk/shale-apps/shale-test-tiger/src/main/java/org/apache/shale/examples/test/tiger/RequestBean.java
MODIFY /shale/framework/trunk/shale-tiger/src/main/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
MODIFY /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/faces/ShaleApplicationFilter.java
MODIFY /shale/framework/trunk/shale-tiger/src/main/java/org/apache/shale/tiger/view/faces/LifecycleListener2.java
MODIFY /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/view/faces/LifecycleListener.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/VariableResolverImplTestCase.java
DEL /shale/framework/trunk/shale-tiger/src/main/java/org/apache/shale/tiger/faces/LifecycleListener.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/VariableResolverImpl5TestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-test-tiger/src/main/java/org/apache/shale/examples/test/tiger/SessionBean.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/VariableResolverImpl4TestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-test-tiger/src/main/webapp/managed.jsp
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/view/faces/LifecycleListener2TestCase.java

Craig McClanahan added a comment - 19/Aug/06 02:50 AM
The underlying problem was that the configuration processing needed to drive annotated managed beans was only being performed if you configured ShaleApplicationFilter. This was resolved by transferring configuration responsibility for configuration processing into org.apache.shale.tiger.view.faces.LifecycleListener2, which is initialized without any explicit configuration being required, if shale-tiger.jar is included in the app.

Fixed in nightly build 20060819. Will be included in 1.0.3.

Craig McClanahan made changes - 19/Aug/06 02:50 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
sean schofield made changes - 21/Aug/06 11:28 PM
Fix Version/s 1.0.3 [ 21750 ]
Fix Version/s 1.0.3-SNAPSHOT [ 21714 ]
Jeff Turner made changes - 09/Aug/07 07:16 AM
Workflow Struts [ 38640 ] Struts - editable closed status [ 42240 ]
Antonio Petrelli made changes - 08/Jan/09 08:57 AM
Workflow Struts - editable closed status [ 42240 ] Struts - editable closed status (temporary) [ 46247 ]
Antonio Petrelli made changes - 08/Jan/09 09:08 AM
Workflow Struts - editable closed status (temporary) [ 46247 ] Struts - editable closed status [ 52890 ]