Issue Details (XML | Word | Printable)

Key: SHALE-255
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Andrew Gilette
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Shale

Subview doing processDecode on beginEncode

Created: 15/Aug/06 03:47 AM   Updated: 21/Aug/06 11:28 PM
Component/s: Core
Affects Version/s: 1.0.3-SNAPSHOT
Fix Version/s: 1.0.3


 Description  « Hide
inputText components within a shale:subview are giving the following warning "There should always be a submitted value for an input if it is rendered, its form is submitted, and it is not disabled or read-only" when the components are first created(When navigating to a new page the components on the new page are giving the error).

I believe it is because of the following code in org.apache.shale.component.Subview

public void encodeBegin(FacesContext context) {

        Object vc = getViewController(context, false);
        if (vc != null) {
            try {
                getViewControllerCallbacks(context).prerender(vc);
            } catch (Exception e) {
                handleException(context, e);
            }
        }
        super.processDecodes(context);

    }

Shouldn't it be....

public void encodeBegin(FacesContext context) throws IOException{

        Object vc = getViewController(context, false);
        if (vc != null) {
            try {
                getViewControllerCallbacks(context).prerender(vc);
            } catch (Exception e) {
                handleException(context, e);
            }
        }
        super.encodeBegin(context);

    }

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Craig McClanahan added a comment - 18/Aug/06 10:32 PM
D'oh ... it certainly should delegate to the encodeBegin() method. Fixed in nightly build 20060819, and will include this fix in 1.0.3. Thanks for the patch!