Issue Details (XML | Word | Printable)

Key: SHALE-249
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Craig McClanahan
Reporter: Craig McClanahan
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Shale

Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase

Created: 10/Aug/06 05:02 PM   Updated: 21/Aug/06 11:28 PM
Return to search
Component/s: Test
Affects Version/s: None
Fix Version/s: 1.0.3


 Description  « Hide
(From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e&gt;)

In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.


 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #430986 Sat Aug 12 07:11:04 UTC 2006 craigmcc Adjust the method signatures of setUp() and tearDown() methods to
include "throws Exception" to be consistent with the base TestClass
implementation in JUnit. For good measure, change these methods from
public to protected scope as well.

SHALE-249
Files Changed
MODIFY /shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/DesigntimeTestCase.java
MODIFY /shale/framework/trunk/shale-test/src/test/java/org/apache/shale/test/mock/MockObjectsTestCase.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/LifecycleListenerTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/validator/CommonsValidatorTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/util/TokenProcessorTestCase.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/config/FacesConfigParserTestCase.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/VariableResolverImpl5TestCase.java
MODIFY /shale/framework/trunk/shale-test/src/test/java/org/apache/shale/test/mock/ValueBindingTest.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/view/faces/LifecycleListener2TestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/AbstractSessionBeanTestCase.java
MODIFY /shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/CommentTestCase.java
MODIFY /shale/framework/trunk/shale-remoting/src/test/java/org/apache/shale/remoting/impl/ChainProcessorTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/ConcreteFacesBeanTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/AbstractApplicationBeanTestCase.java
MODIFY /shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/jmock/AbstractJmockJsfTestCase.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/VariableResolverImplTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/ConcreteViewControllerTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/validator/ValidatorDefaultTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/dialog/config/ConfigurationParserTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/faces/ViewControllerCallbacksTestCase.java
MODIFY /shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/base/AbstractJsfTestCase.java
MODIFY /shale/framework/trunk/shale-remoting/src/test/java/org/apache/shale/remoting/XhtmlHelperTestCase.java
MODIFY /shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/AbstractTestCaseConfig.java
MODIFY /shale/framework/trunk/shale-remoting/src/test/java/org/apache/shale/remoting/impl/MappingImplTestCase.java
MODIFY /shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/htmlunit/AbstractHtmlUnitTestCase.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/faces/VariableResolverImpl4TestCase.java
MODIFY /shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/OptimizeTreeTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/dialog/impl/ImplClassesTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/impl/DefaultViewControllerMapperTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/util/MessagesTestCase.java
MODIFY /shale/framework/trunk/shale-remoting/src/test/java/org/apache/shale/remoting/impl/MethodBindingProcessorTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view/AbstractRequestBeanTestCase.java
MODIFY /shale/framework/trunk/shale-remoting/src/test/java/org/apache/shale/remoting/impl/ClassResourceProcessorTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/util/LoadBundleTestCase.java
MODIFY /shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/utils/ClayAmalgamTestCase.java
MODIFY /shale/framework/trunk/shale-tiger/src/test/java/org/apache/shale/tiger/view/faces/ViewControllerCallbacks2TestCase.java
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/dialog/faces/DialogNavigationHandlerTestCase.java

Repository Revision Date User Message
ASF #431085 Sat Aug 12 20:56:13 UTC 2006 craigmcc Update webapp test cases to the "throws Exception" change as well
(forgot to check these in last night).

SHALE-249
Files Changed
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/SubviewTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/locale/SelectTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/lookup/ListCategoriesTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-blank/src/test/java/org/apache/shale/blank/systest/WelcomeTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-blank/src/test/java/org/apache/shale/blank/WelcomeBeanTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/JndiTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/TokenTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/AbstractTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/remote/ListLocalesTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/ViewControllerTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/remote/ListCategoriesTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/ExceptionTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/UseCasesTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/remote/ListStateNamesTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-clay-usecases/src/test/java/org/apache/shale/usecases/rolodex/RolodexTestCase.java
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/lookup/ListLocalesTestCase.java