s:validatorScript produces invalid html markup

• Key: SHALE-247
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Gary VanMatre
• Reporter: Reind
• Component/s: Core
• Affects Version/s: 1.0.2
• Fix Version/s: 1.0.3

Description

The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.

The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.

Output:
<script type="text/javascript" language="Javascript1.1">
<!--
<!--
var bCancel = false;
...
-->
//-->
Fix:

<script type="text/javascript" language="Javascript1.1"><!--

var bCancel = false;
...
...
//-->

Comments

[Reind]

This patch makes a small change to:

org.apache.shale.component.ValidatorScript.writeScriptStart(ResponseWriter writer)
and
org.apache.shale.component.ValidatorScript.writeScriptEnd(ResponseWriter writer)

It removes the "<!--\n" from the former and "-->\n" from the later.

This fixes the xhtml validation issues - and, hopefully, doesn't cause any other issues.

[Reind]

Edit:
The attached patch is for 1.0.2 , not the nightly build. There seems to be another issue with validatorScript in the nightlies

[Reind]

Just wanted to add. I checked out a new copy of shale from subversion and validatorScript works (contrary to my previous post). Incidentally the patch work as well.

[Gary VanMatre]

I must have addressed this one in SHALE-217. But, thanks for the patch.

[Gary VanMatre]

Fixed with another resolution, SHALE-217.

[Gary VanMatre]

The patch should be available in the 20060807 nightly. Thanks for the help.