Issue Details (XML | Word | Printable)

Key: SHALE-194
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Gary VanMatre
Reporter: Jack Cheng
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Shale

javascript validation function errors in Shale 1.0.3

Created: 18/Jun/06 11:57 AM   Updated: 21/Aug/06 11:28 PM
Return to search
Component/s: Core
Affects Version/s: Nightly
Fix Version/s: 1.0.3

Environment: All operating systems and browsers


 Description  « Hide
the callback functions generated by ValidatorScript component will cause the following javascript error on FireFox and IE:
Error: missing ( before formal parameters
Source File: http://localhost:8080/ebusiness/modules/account/create.jsf
Line: 279, Column: 13
Source Code:
function page:_id0:_id1:_id7:_id13:create_account_form_email() {

this is due to the presence of colons in the callback function name and
only happens if you have a form in an html page that is processed by a
clay tag on a JSP page. Shale 1.0.2 works fine.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Wendy Smoak added a comment - 18/Jun/06 12:03 PM
Fixed versions.

Wendy Smoak made changes - 18/Jun/06 12:03 PM
Field Original Value New Value
Affects Version/s 1.0.3 [ 21714 ]
Fix Version/s 1.0.3 [ 21714 ]
Affects Version/s Nightly [ 21715 ]
Repository Revision Date User Message
Struts #415235 Mon Jun 19 03:13:33 UTC 2006 gvanmatre Fix for issue SHALE-194 reported by Jack Cheng.
Files Changed
ADD /struts/shale/trunk/shale-core/src/main/resources/org/apache/shale/validator/validateUtilities.js
MODIFY /struts/shale/trunk/shale-clay/src/main/java/org/apache/shale/clay/parser/builder/ElementBuilder.java
MODIFY /struts/shale/trunk/shale-apps/shale-clay-usecases/src/main/webapp/rolodex/xhrolodex.html
MODIFY /struts/shale/trunk/shale-clay/src/main/java/org/apache/shale/clay/parser/builder/Builder.java
MODIFY /struts/shale/trunk/shale-apps/shale-clay-usecases/src/main/webapp/WEB-INF/clay-config.xml
MODIFY /struts/shale/trunk/shale-apps/shale-usecases/src/main/webapp/validator/test.jsp
MODIFY /struts/shale/trunk/shale-core/src/main/resources/org/apache/shale/validator/validator-rules.xml
MODIFY /struts/shale/trunk/shale-core/src/test/java/org/apache/shale/validator/CommonsValidatorTestCase.java
MODIFY /struts/shale/trunk/shale-apps/shale-clay-usecases/src/main/webapp/rolodex/hrolodex.html
MODIFY /struts/shale/trunk/shale-clay/src/main/java/org/apache/shale/clay/parser/builder/JsfDefaultBuilder.java
MODIFY /struts/shale/trunk/shale-apps/shale-clay-usecases/src/main/webapp/rolodex/jsprolodex.jsp
MODIFY /struts/shale/trunk/shale-apps/shale-clay-usecases/src/main/webapp/rolodex/jrolodex.html
MODIFY /struts/shale/trunk/shale-core/src/main/java/org/apache/shale/component/ValidatorScript.java

Gary VanMatre added a comment - 19/Jun/06 10:20 AM
Added logic to strip out the UINamingContainer.SEPARATOR_CHAR and created our own version of the javascript that strips out the same colon character when resolving the form name. Added the email commonsValidator to the shale clay usecases rolodex example. I also added a subview to the shale usecases validator example.

I appreciate the help Jack.

Gary VanMatre made changes - 19/Jun/06 10:20 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Assignee Gary VanMatre [ gvanmatre@comcast.net ]
sean schofield made changes - 21/Aug/06 11:28 PM
Fix Version/s 1.0.3 [ 21750 ]
Fix Version/s 1.0.3-SNAPSHOT [ 21714 ]
Jeff Turner made changes - 09/Aug/07 07:16 AM
Workflow Struts [ 38459 ] Struts - editable closed status [ 42116 ]
Antonio Petrelli made changes - 08/Jan/09 08:57 AM
Workflow Struts - editable closed status [ 42116 ] Struts - editable closed status (temporary) [ 46179 ]
Antonio Petrelli made changes - 08/Jan/09 09:08 AM
Workflow Struts - editable closed status (temporary) [ 46179 ] Struts - editable closed status [ 52833 ]