Issue Details (XML | Word | Printable)

Key: SHALE-191
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Adam Brod
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Shale

Consider renaming @Value to @Property

Created: 13/Jun/06 07:19 PM   Updated: 21/Aug/06 11:28 PM
Return to search
Component/s: Tiger
Affects Version/s: 1.0.3-SNAPSHOT
Fix Version/s: 1.0.3


 Description  « Hide
I find it very confusing to use the annotation @Value for a managed property. I think in terms of the faces-config.xml file, "Managed Beans" and "Managed Properties". If I want to configure a managed bean with Shale-Tiger, I annotate my class with the @Bean. If I want to configure my managed property, I would expect to annotate my property with @Property. Since annotations have a value attribute, it makes sense to me that @Property("#{param.id}") would read as "managed property with value #{param.id}".

In Shale-Tiger 1.0.3, I have to annotate my property with @Value. When I look at my code (@Value("#{param.id}")) , it doesn't read very well. "Managed value with value #{param.id}".

I think it would make more sense to use @Property instead of @Value. I noticed that Craig accidentally used @Property in an email as well, so clearly I'm not the only one who thinks in terms of @Property and not @Value - http://www.nabble.com/Re%3A--Shale--tiger---abstract-base-class--p4838056.html :)

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Craig McClanahan made changes - 27/Jun/06 12:44 PM
Field Original Value New Value
Fix Version/s 1.0.3 [ 21714 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
sean schofield made changes - 21/Aug/06 11:28 PM
Fix Version/s 1.0.3 [ 21750 ]
Fix Version/s 1.0.3-SNAPSHOT [ 21714 ]
Jeff Turner made changes - 09/Aug/07 07:16 AM
Workflow Struts [ 38448 ] Struts - editable closed status [ 42226 ]
Antonio Petrelli made changes - 08/Jan/09 08:57 AM
Workflow Struts - editable closed status [ 42226 ] Struts - editable closed status (temporary) [ 46238 ]
Antonio Petrelli made changes - 08/Jan/09 09:08 AM
Workflow Struts - editable closed status (temporary) [ 46238 ] Struts - editable closed status [ 52622 ]