Issue Details (XML | Word | Printable)

Key: SHALE-182
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Craig McClanahan
Reporter: Veit Guna
Votes: 1
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Shale

s:token tag doesn't allow sending a form, when any validation error occurs on page

Created: 01/Jun/06 03:16 AM   Updated: 29/Jun/06 03:34 AM
Return to search
Component/s: Core
Affects Version/s: Nightly
Fix Version/s: 1.0.3-SNAPSHOT

Environment: Windows XP, Tomcat 5.5, Myfaces 1.1.1 + Facelets 1.1.2, shale core 1.0.3-SNAPSHOT (shale-framework-20060530.zip)


 Description  « Hide
When using the token tag to avoid double submits, it doesn't allow the form to be submitted if any validation error occurs (e.g. required). It then says, that
the form has already been submitted and stays on the page.

I consider this as a bug...


 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
Struts #410891 Thu Jun 01 17:04:20 UTC 2006 craigmcc Add a use case that, when run manually, can illustrate the SHALE-182 issue.
Next step will be an automated test for it, plus a fix to the underlying bug.
Files Changed
MODIFY /struts/shale/trunk/use-cases/src/web/WEB-INF/faces-config.xml
MODIFY /struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/view/Bundle.properties
ADD /struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/token/Test.java
ADD /struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/token
ADD /struts/shale/trunk/use-cases/src/web/token/test.jsp
MODIFY /struts/shale/trunk/use-cases/src/web/usecases.jsp
ADD /struts/shale/trunk/use-cases/src/web/token

Repository Revision Date User Message
Struts #410909 Thu Jun 01 18:38:45 UTC 2006 craigmcc Add a system integration to validate the token processing behavior. There is
a section of this test that is commented out until SHALE-182 is fixed in the
token processing implementation.
Files Changed
ADD /struts/shale/trunk/use-cases/src/systest/org/apache/shale/usecases/systest/TokenTestCase.java
MODIFY /struts/shale/trunk/use-cases/src/web/token/test.jsp

Repository Revision Date User Message
Struts #414006 Tue Jun 13 23:52:15 UTC 2006 craigmcc Add a system integration test to validate the token processing behavior.
There is a section of this test that is commented out until SHALE-182 is
fixed in the token processing implementation.

This integration mirrors r410909 on the trunk, which was integrated after
the "mvn_reorg" branch was created.
Files Changed
ADD /struts/shale/branches/mvn_reorg/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/TokenTestCase.java (from /struts/shale/trunk/use-cases/src/systest/org/apache/shale/usecases/systest/TokenTestCase.java)
MODIFY /struts/shale/branches/mvn_reorg/shale-apps/shale-usecases/src/main/webapp/token/test.jsp

Repository Revision Date User Message
Struts #417306 Mon Jun 26 22:36:38 UTC 2006 craigmcc Fix issue SHALE-182 (token tag would not allow resubmit after validation
error was corrected). Re-enable the system integration test that verifies
this behavior.
Files Changed
MODIFY /struts/shale/trunk/shale-core/src/main/java/org/apache/shale/component/Token.java
MODIFY /struts/shale/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/systest/TokenTestCase.java