Index: DriverManagerConnectionFactory.java =================================================================== RCS file: /home/cvspublic/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DriverManagerConnectionFactory.java,v retrieving revision 1.8 diff -u -r1.8 DriverManagerConnectionFactory.java --- DriverManagerConnectionFactory.java 28 Feb 2004 12:18:17 -0000 1.8 +++ DriverManagerConnectionFactory.java 23 Jun 2004 17:12:31 -0000 @@ -25,6 +25,7 @@ * * @author Rodney Waldhoff * @author Ignacio J. Ortega + * @author Max Grender-Jones * @version $Revision: 1.8 $ $Date: 2004/02/28 12:18:17 $ */ public class DriverManagerConnectionFactory implements ConnectionFactory { @@ -42,7 +43,7 @@ public Connection createConnection() throws SQLException { if(null == _props) { - if((_uname == null) || (_passwd == null)) { + if((_uname == null) && (_passwd == null)) { return DriverManager.getConnection(_connectUri); } else { return DriverManager.getConnection(_connectUri,_uname,_passwd);