[#XALANJ-2285] count function applied to union as test of node identity is broken

XalanJ2

count function applied to union as test of node identity is broken

Created: 29/Mar/06 05:18 AM Updated: 11/Dec/07 04:34 PM

Return to search

Component/s:

XSLTC

Affects Version/s:

2.7

Fix Version/s:

2.7.1

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
j2285.out	2006-03-29 05:28 AM	Henry Zongaro	0.4 kB
j2285.xml	2006-03-29 05:28 AM	Henry Zongaro	0.1 kB
j2285.xsl	2006-03-29 05:28 AM	Henry Zongaro	0.9 kB
patch.j2285.txt	2006-05-10 01:51 AM	Henry Zongaro	0.6 kB

Issue Links:

Duplicate

This issue is duplicated by:

~~XALANJ-2390~~ count( $x |. ) != count( $x ) not working as expected

Xalan info:	PatchAvailable
Reviewer:	Christine Li
Resolution Date:	08/Jun/06 03:28 AM

Description

« Hide

Using "count(.|$foo) = 1", where $foo is a node set consisting of one node, to test for node identity appears to be broken; it's always returning the value one. It worked in Xalan-J 2.7.0. It appears to have been broken with the patch for ~~XALANJ-2097~~.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Henry Zongaro added a comment - 29/Mar/06 05:28 AM

Attaching stylesheet, input document and expected output.

Henry Zongaro made changes - 29/Mar/06 05:28 AM

Field	Original Value	New Value
Attachment		j2285.out [ 12324684 ]
Attachment		j2285.xml [ 12324683 ]
Attachment		j2285.xsl [ 12324682 ]

[ Permlink | « Hide ]

Henry Zongaro added a comment - 29/Mar/06 05:35 AM

This is an issue against XSLTC. See ~~XALANJ-2286~~ for a bug in Xalan-J Interpretive with the same test case.

Henry Zongaro made changes - 05/Apr/06 02:24 AM

Assignee

Henry Zongaro [ zongaro@ca.ibm.com ]

[ Permlink | « Hide ]

Brian Minchau added a comment - 05/Apr/06 03:50 AM

Comments from Xalan-J triage April 4, 2006:
> This Xalan-J interpretive bug has different breakage than
> This worked for 2.7.0 but has broken during development.
> Currently the count() function in the testcase always returns 2 or 3
regardless of what it should return.
> This is a commonly used way of testing identity in XSLT 1.0
> The fix for ~~XALANJ-2097~~ may have further exposed this problem,
> not that ~~XALANJ-2097~~ was itself a regression

Henry Zongaro made changes - 10/May/06 01:51 AM

Attachment

patch.j2285.txt [ 12326465 ]

Henry Zongaro made changes - 10/May/06 01:52 AM

Xalan info

[PatchAvailable]

[ Permlink | « Hide ]

Christine Li added a comment - 01/Jun/06 09:08 PM

The patch looks good to me. It resolves the described problem.

Repository	Revision	Date	User	Message
ASF	#412510	Wed Jun 07 19:55:06 UTC 2006	zongaro	Fix for ~~XALANJ-2285~~. The SingletonIterator wasn't allowing itself to be sensitive to a change in the context node (through setStartNode) more than once. Reviewed by Christine Li (jycli () ca ! ibm ! com)
				Files Changed
				MODIFY /xalan/java/trunk/src/org/apache/xml/dtm/ref/DTMDefaultBaseIterators.java

Henry Zongaro made changes - 08/Jun/06 03:27 AM

reviewer

jycli@ca.ibm.com

[ Permlink | « Hide ]

Henry Zongaro added a comment - 08/Jun/06 03:28 AM

Applied patch in source repository.

Henry Zongaro made changes - 08/Jun/06 03:28 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		Latest Development Code [ 10863 ]

[ Permlink | « Hide ]

Henry Zongaro added a comment - 31/Oct/06 06:11 PM

I've confirmed that the problem is fixed in the current source repository.

Henry Zongaro made changes - 31/Oct/06 06:11 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Henry Zongaro made changes - 18/Jul/07 03:27 PM

Link

This issue is duplicated by ~~XALANJ-2390~~ [ ~~XALANJ-2390~~ ]

[ Permlink | « Hide ]

Brian Minchau added a comment - 11/Dec/07 04:34 PM

The fixed version is marked as 2.7.1.
The affecteced version was marked as 2.7.1, which is clearly wrong.
Changing the affected version to 2.7, which is better, though perhaps not fully accurate.

Brian Minchau made changes - 11/Dec/07 04:34 PM

Affects Version/s	2.7.1 [ 10863 ]
Affects Version/s		2.7 [ 11080 ]