[#XALANJ-2284] [PATCH] remove needless synchronization

XalanJ2

[PATCH] remove needless synchronization

Created: 20/Mar/06 08:23 AM Updated: 09/Jan/08 03:56 AM

Return to search

Component/s:

None

Affects Version/s:

2.7

Fix Version/s:

2.7.1

Security Level:

No security risk; visible to anyone (Ordinary problems in Xalan projects. Anybody can view the issue.)

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	remove_needless_synchronization.diff	2006-03-20 08:25 AM	Dave Brosius	16 kB

Issue Links:

Duplicate

This issue is duplicated by:

~~XALANJ-2283~~ [PATCH] remove needless synchronization

Xalan info:	PatchAvailable
Fix priority:	fp4
Reviewer:	Brian Minchau
Resolution Date:	31/Oct/06 10:41 PM

Description

« Hide

several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Brian Minchau added a comment - 05/Apr/06 03:33 AM

Comments from Xalan-J triage on April 4, 2006:
> Henry Z. agreed to review the patch.

[ Permlink | « Hide ]

Brian Minchau added a comment - 17/Oct/06 06:30 AM

I'll wait for Henry's comments on this patch.
His preliminary communication is that this patch is OK,
but it imples that we drop runtime support for 1.1.x and move
to 1.2 and up. Waiting for consensus from users and from
the PMC on moving to 1.2

[ Permlink | « Hide ]

Brian Minchau added a comment - 31/Oct/06 09:14 PM

The PMC has voted to drop support for JRE 1.1x, meaning that we now support 1.2 runtime and up.

Henry can now review the patch with that in mind.

[ Permlink | « Hide ]

Brian Minchau added a comment - 31/Oct/06 09:15 PM

Assigning to Henry Z. to review/apply the patch.

[ Permlink | « Hide ]

Brian Minchau added a comment - 31/Oct/06 10:36 PM

I have reviewed and tested the patch, and I approve it.

[ Permlink | « Hide ]

Brian Minchau added a comment - 31/Oct/06 10:41 PM

The patch is now applied to the latest development code and resolved.

[ Permlink | « Hide ]

Brian Minchau added a comment - 11/Dec/07 03:16 PM

This issue is no longer relevant for 2.7.1, it is fixed in 2.7.1.
Changing the affected version to 2.7.

[ Permlink | « Hide ]

Brian Minchau added a comment - 11/Dec/07 04:57 PM

Would the originator of this issue please verify that this issue is fixed in the 2.7.1 release, by adding a comment to this issue, so that we can close this issue.

A lack of response by February 1, 2008 will be taken as consent that we can close this resolved issue.

Regards,
Brian Minchau

[ Permlink | « Hide ]

Dave Brosius added a comment - 09/Jan/08 03:56 AM

Fixed

[ Permlink | « Hide ]

Dave Brosius added a comment - 09/Jan/08 03:56 AM

Patch applied correctly