Issue Details (XML | Word | Printable)

Key: XALANJ-2275
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Brian Minchau
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
XalanJ2

Serializer's methods to set xsl:output properties is brittle.

Created: 08/Mar/06 06:09 AM   Updated: 12/Dec/07 03:36 AM
Return to search
Component/s: None
Affects Version/s: 2.7
Fix Version/s: 2.7.1

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works patch2.txt 2006-03-08 06:17 AM Brian Minchau 54 kB

Resolution Date: 08/Mar/06 08:00 AM


 Description  « Hide
The serializer's code to set values from xsl:output attributes is brittle.

Setting a writer or OutputStream involves internal "init" methods that take java.util.Properties objects. Setting an OutputStream should not need to do all that. The only interaction with the properties is the encoding, which would be used in the creation of the java.io.Writer that wraps the OutputStream, but that is about it.

The code is also brittle with respect to whether the values set are default values or explicit values,
say from a stylesheet or from JAXP APIs.

In the long run many methods on the serializer's XSLOutputAttributes interface should go away.
In their place a more generic methods should exist:

public void setOutputPropertyDefault(String name, String val);
public void setOutputProperty(String name, String val);

public String getOutputPropertyDefault(String name);
public String getOutputProperty(String name);

Through these methods one can set/get a default or non-default property.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Brian Minchau made changes - 08/Mar/06 06:17 AM
Field Original Value New Value
Attachment patch2.txt [ 12323883 ]
Brian Minchau made changes - 08/Mar/06 08:00 AM
Fix Version/s Latest Development Code [ 10863 ]
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Brian Minchau made changes - 11/Dec/07 03:16 PM
Affects Version/s 2.7 [ 11080 ]
Affects Version/s 2.7.1 [ 10863 ]
Brian Minchau made changes - 12/Dec/07 03:36 AM
Status Resolved [ 5 ] Closed [ 6 ]