[#XALANJ-2221] [PATCH] System.arraycopy is more efficient, so use it

XalanJ2

[PATCH] System.arraycopy is more efficient, so use it

Created: 28/Oct/05 02:24 PM Updated: 09/Jan/08 03:38 AM

Return to search

Component/s:

None

Affects Version/s:

2.7

Fix Version/s:

2.7.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	system_arraycopy.diff	2005-10-28 02:26 PM	Dave Brosius	1 kB

Xalan info:	PatchAvailable
Resolution Date:	16/Oct/06 04:35 PM

Description

« Hide

System.arraycopy is better performing that simple manual array copying in a loop

1) It's native
2) it avoids all the array range check, except one up front.

This patch changes this.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Brian Minchau added a comment - 02/Nov/05 05:39 AM

Assigned to John Gentilin to review the patch (per JIRA meeting Nov 1, 2005).

[ Permlink | « Hide ]

Brian Minchau added a comment - 16/Oct/06 04:30 PM

I have reviewed and approve the patch.

[ Permlink | « Hide ]

Brian Minchau added a comment - 16/Oct/06 04:35 PM

Resolved, I applied the patch was applied to the latest development code.

[ Permlink | « Hide ]

Brian Minchau added a comment - 11/Dec/07 03:16 PM

This issue is no longer relevant for 2.7.1, it is fixed in 2.7.1.
Changing the affected version to 2.7.

[ Permlink | « Hide ]

Brian Minchau added a comment - 11/Dec/07 04:57 PM

Would the originator of this issue please verify that this issue is fixed in the 2.7.1 release, by adding a comment to this issue, so that we can close this issue.

A lack of response by February 1, 2008 will be taken as consent that we can close this resolved issue.

Regards,
Brian Minchau

[ Permlink | « Hide ]

Dave Brosius added a comment - 09/Jan/08 03:38 AM

Fixed

[ Permlink | « Hide ]

Dave Brosius added a comment - 09/Jan/08 03:38 AM

Patch applied correctly