[#XALANJ-2209] [PATCH] invalid code tries to compare unrelated objects

XalanJ2

[PATCH] invalid code tries to compare unrelated objects

Created: 11/Oct/05 12:18 PM Updated: 17/Oct/06 06:24 AM

Return to search

Component/s:

XSLTC

Affects Version/s:

2.7.1

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	fix_equals.diff	2005-10-11 12:18 PM	Dave Brosius	0.9 kB

Xalan info:	PatchAvailable
Reviewer:	Brian Minchau

Description

« Hide

A QName is attempted to be .equals with a string. This will always be false. compare the stringrep instead

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Brian Minchau added a comment - 02/Nov/05 05:47 AM

Assiging Henry Z. as the patch reviewer, per the JIRA meeting Nov. 1, 2005.

[ Permlink | « Hide ]

Henry Zongaro added a comment - 16/Oct/06 02:07 PM

I have reviewed the attached patch.[1] Although the change is correct, the code that it guards is redundant, and the entire check and error should be removed instead. Just a few lines above in AttributeSet.parseContents, there is a check of whether the "name" attribute contains a valid QName.

[1] http://issues.apache.org/jira/secure/attachment/12314816/fix_equals.diff

[ Permlink | « Hide ]

Brian Minchau added a comment - 17/Oct/06 06:23 AM

Per the JIRA meeting on Oct 16, 2005, Henry has agreed to provide and alternate patch, and Brian M. will review it.