[#XALANJ-2061] [Patch] Cleanup some dead code

XalanJ2

[Patch] Cleanup some dead code

Created: 17/Feb/05 01:04 PM Updated: 09/Jan/08 04:26 AM

Return to search

Component/s:

None

Affects Version/s:

2.7

Fix Version/s:

2.7.1

Security Level:

No security risk; visible to anyone (Ordinary problems in Xalan projects. Anybody can view the issue.)

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	simple_dls.patch	2005-02-17 01:05 PM	Dave Brosius	13 kB

Issue Links:

Reference

This issue is related to:

XALANJ-2331 StringValueHandler.setEscaping() doesn't return old escaping value

Xalan info:	PatchAvailable
Fix priority:	fp5
Resolution Date:	30/Oct/06 10:44 PM

Description

« Hide

This patch cleans up some unused code

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Brian Minchau added a comment - 02/Mar/05 05:01 AM

Per the JIRA committer meeting March 1, I'm assigning to Ilene to review the patch.

[ Permlink | « Hide ]

Brian Minchau added a comment - 17/Oct/06 06:19 AM

Per the JIRA meeting on Oct 16, 2005 Brian M. agreed to review this patch.

[ Permlink | « Hide ]

Brian Minchau added a comment - 30/Oct/06 10:43 PM

I approve, and have applied the following parts of Dave Brosius patch to the latest development code:

ExsltDatetime.java
ProcessorExsltFunction.java
XSLTAttributeDef.java
XSLTAttributeDef.java
ElemAttribute.java
TransformerIdentityImpl.java
TransformerImpl.java
ApplyImport.java
FunctionAvailable.java
MethodGenerator.java
FastStringBuffer.java
SelfIteratorNoPredicate.java

I did not apply the fix to Version.java because this is a generated part.

I did not apply the fix to ExtensionHandlerExsltFunction.java because this last store to a variable
that is never used is dead code, but then so is a bunch of code leading up to that store.
I'd rather just leave it alond for now rather than upset the apple cart.

I did not apply the fix to StylesheetHandler.java because it is wrong. The line
to be deleted by that part of the patch is not dead code at all.

I did not apply the fix to StringValueHandler.java because that dead code
actually exposed a bug. It should not be dead code at all. Another issue, XALANJ-2331 now
track this.

[ Permlink | « Hide ]

Brian Minchau added a comment - 30/Oct/06 10:44 PM

Resolving as fixed, most parts of the patch were applied.

[ Permlink | « Hide ]

Brian Minchau added a comment - 11/Dec/07 04:57 PM

Would the originator of this issue please verify that this issue is fixed in the 2.7.1 release, by adding a comment to this issue, so that we can close this issue.

A lack of response by February 1, 2008 will be taken as consent that we can close this resolved issue.

Regards,
Brian Minchau

[ Permlink | « Hide ]

Dave Brosius added a comment - 09/Jan/08 04:26 AM

Fixed

[ Permlink | « Hide ]

Dave Brosius added a comment - 09/Jan/08 04:26 AM

Patch applied correctly (with noted differences)