Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9934

SolrTestCase.clearIndex should ensure IndexWriter.deleteAll is called

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Test
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 6.4, 7.0
    • None
    • None

    Description

      Normal deleteByQuery commands are subject to version constraint checks due to the possibility of out of order updates, but DUH2 has special support (triggered by version=-Long.MAX_VALUE for use by tests to override these version constraints and do a low level IndexWriter.deleteAll() call. A handful of tests override SolrTestCaseJ4.clearIndex() to take advantage of this (using copy/pasted impls), but given the intended purpose/usage of SolrTestCaseJ4.clearIndex(), it seems like the the base method in SolrTestCaseJ4 should itself trigger this low level deletion, so tests get this behavior automatically.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hossman Chris M. Hostetter
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment