[ZOOKEEPER-2873] print error and/or abort on invalid server definition

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.10
• Fix Version/s: 3.4.13, 3.5.5
• Component/s: server
• Labels: pull-request-available
• Assignee: Norbert Kalmár
• Reporter: Christopher Smith
• Created: 10/Aug/17 21:37
• Updated: 17/Jul/18 04:50
• Resolved: 04/Jul/18 15:12

Description

While bringing up a new cluster, I managed to fat-finger a sed script and put some lines like this into my config file:

server.1=zookeeper1:2888:2888

This led to a predictable spew of error messages when the client and election components fought over the single port. Since a configuration of this case is always an error, I suggest that it would be sensible to abort the server startup if an entry is found with the same port for both client and election. (Logging the error explicitly without shutting down is less helpful because of how fast the logs pile up.)

Issue Links

• links to: GitHub Pull Request #549