[ZOOKEEPER-2732] Cleanup findbug warnings in branch-3.4: Performance Warnings

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.4.11
• Assignee: Abraham Fine
• Reporter: Rakesh Radhakrishnan
• Created: 20/Mar/17 05:25
• Updated: 22/May/17 17:58
• Resolved: 22/May/17 04:26

Description

Please refer the attached sheet in parent jira. Below is the details of findbug warnings.

Bx	Boxing/unboxing to parse a primitive new org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map, QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean)
Bx	new org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map, QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead
Dm	org.apache.zookeeper.server.quorum.FastLeaderElection$Notification.toString() invokes inefficient new String(String) constructor
WMI	org.apache.zookeeper.server.DataTree.dumpEphemerals(PrintWriter) makes inefficient use of keySet iterator instead of entrySet iterator
WMI	org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.computeGroupWeight() makes inefficient use of keySet iterator instead of entrySet iterator
WMI	org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.containsQuorum(HashSet) makes inefficient use of keySet iterator instead of entrySet iterator
WMI	org.apache.zookeeper.ZooKeeperMain.usage() makes inefficient use of keySet iterator instead of entrySet iterator

Issue Links

• links to: GitHub Pull Request #231
• links to: GitHub Pull Request #258