[ZOOKEEPER-2572] Potential resource leak in FileTxnLog.truncate

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.4.9, 3.5.2, 3.4.11
• Component/s: server
• Labels: pull-request-available
• Assignee: Ling Mao
• Reporter: Michael Han
• Created: 09/Sep/16 05:50
• Updated: 28/Mar/20 15:07

Description

In FileTxnLog.truncate, we have:

public boolean truncate(long zxid) throws IOException {
        FileTxnIterator itr = null;
        try {
            itr = new FileTxnIterator(this.logDir, zxid);
            PositionInputStream input = itr.inputStream;
            if(input == null) {
                throw new IOException("No log files found to truncate! This could " +
                        "happen if you still have snapshots from an old setup or " +
                        "log files were deleted accidentally or dataLogDir was changed in zoo.cfg.");
            }
            long pos = input.getPosition();
            // now, truncate at the current position
            RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
            raf.setLength(pos);
            raf.close();
            while(itr.goToNextLog()) {
                if (!itr.logFile.delete()) {
                    LOG.warn("Unable to truncate {}", itr.logFile);
                }
            }
        } finally {
            close(itr);
        }
        return true;
    }

raf here can be potentially in a state of not closed after leaving the method, if there is an (IO) exception thrown from setLength.

Issue Links

• links to: GitHub Pull Request #356
• links to: GitHub Pull Request #356