[ZOOKEEPER-2517] jute.maxbuffer is ignored

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.5.2
• Fix Version/s: 3.5.3, 3.6.0
• Assignee: Mohammad Arshad
• Reporter: Benjamin Jaton
• Created: 18/Aug/16 23:41
• Updated: 18/May/17 03:43
• Resolved: 30/Dec/16 22:02

Description

In ClientCnxnSocket.java the parsing of the system property is erroneous:

packetLen = Integer.getInteger(
  clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
  ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
);

Javadoc of Integer.getInteger states "The first argument is treated as the name of a system property", whereas here the value of the property is passed.

Instead I believe the author meant to write something like:

packetLen = Integer.parseInt(
  clientConfig.getProperty(
    ZKConfig.JUTE_MAXBUFFER,
    String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
  )
);

Issue Links

• is broken by: ZOOKEEPER-2139 Support multiple ZooKeeper client, with different configurations, in a single JVM
• links to: GitHub Pull Request #113