[ZOOKEEPER-2228] WorkerReceiver's main loop (in FastLeaderElection's) should break loop upon restart

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Component/s: server
• Assignee: Unassigned
• Reporter: Raúl Gutiérrez Segalés
• Created: 01/Jul/15 23:46
• Updated: 03/Jul/15 01:40
• Resolved: 03/Jul/15 01:40

Description

It seems like in FastLeaderElection#Messenger#WorkerReceiver the main loop should be left immediately after this path [0] is taken:

                                       if (!rqv.equals(curQV)) {
                                           LOG.info("restarting leader election");
                                           self.shuttingDownLE = true;
                                           self.getElectionAlg().shutdown();
                                       }

Instead, it keeps going which means the received message would still be applied and a new message might be send out. Should there be a break statement right after self.getElectionAlg().shutdown()?

Any ideas shralex?

[0]: https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java#L300