[ZOOKEEPER-2193] reconfig command completes even if parameter is wrong obviously

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.1, 3.6.0
• Component/s: leaderElection, server

Environment

CentOS7 + Java7

• Assignee: Yasuhito Fukuda
• Reporter: Yasuhito Fukuda
• Created: 20/May/15 09:38
• Updated: 28/Jul/15 06:49
• Resolved: 27/Jun/15 00:06

Description

Even if reconfig parameter is wrong, it was confirmed to complete.
refer to the following.

• Ensemble consists of four nodes

[zk: vm-101:2181(CONNECTED) 0] config
server.1=192.168.100.101:2888:3888:participant
server.2=192.168.100.102:2888:3888:participant
server.3=192.168.100.103:2888:3888:participant
server.4=192.168.100.104:2888:3888:participant
version=100000000

• add node by reconfig command

[zk: vm-101:2181(CONNECTED) 9] reconfig -add server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
Committed new configuration:
server.1=192.168.100.101:2888:3888:participant
server.2=192.168.100.102:2888:3888:participant
server.3=192.168.100.103:2888:3888:participant
server.4=192.168.100.104:2888:3888:participant
server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
version=300000007

server.4 and server.5 of the IP address is a duplicate.

In this state, reader election will not work properly.
Besides, it is assumed an ensemble will be undesirable state.
I think that need a parameter validation when reconfig.