Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2098

QuorumCnxManager: use BufferedOutputStream for initial msg

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.5.0
    • 3.5.1, 3.6.0
    • quorum, server
    • None

    Description

      Whilst writing fle-dump (a tool like zk-dump, but to dump FastLeaderElection messages), I noticed that QCM is using DataOutputStream (which doesn't buffer) directly.

      So all calls to write() are written immediately to the network, which means simple messaages like two participants exchanging Votes can take a couple RTTs! This is specially terrible for global clusters (i.e.: x-country RTTs).

      The solution is to use BufferedOutputStream for the initial negotiation between members of the cluster. Note that there are other places were suboptimal (but not entirely unbuffered) writes to the network still exist. I'll get those in separate tickets.

      After using BufferedOutputStream we get only 1 RTT for the initial message, so elections & time for for participants to join a cluster is reduced.

      Attachments

        1. ZOOKEEPER-2098.patch
          2 kB
          Raúl Gutiérrez Segalés
        2. ZOOKEEPER-2098.patch
          1 kB
          Raúl Gutiérrez Segalés

        Issue Links

          Activity

            People

              rgs Raúl Gutiérrez Segalés
              rgs Raúl Gutiérrez Segalés
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: