[ZOOKEEPER-2075] Utils.bufEquals

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.4.6
• Component/s: java client
• Assignee: Unassigned
• Reporter: Charlie Helin
• Created: 07/Nov/14 20:22
• Updated: 07/Nov/14 20:22

Description

Just happened to notice Utils.bufEquals(byte[], byte[]) as a rather large outlier (~7% CPU time) when running with an attached profiler.

By just simply switching the implementation to delegate directly to Arrays.equals(byte[], byte[]) the invocation disappears from the profile. The reason for this is that this is one of the methods which the JIT (not the interpreter) will generate an intrinsic for, using the builtin support of the CPU to do the check.

The fix is trivial

    public static boolean bufEquals(byte onearray[], byte twoarray[] ) {
       return Arrays.equals(onearray, twoarray);
    }