[ZOOKEEPER-1990] suspicious instantiation of java Random instances

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.6.0, 3.5.5
• Labels: pull-request-available
• Assignee: Norbert Kalmár
• Reporter: Patrick D. Hunt
• Created: 25/Jul/14 23:33
• Updated: 20/May/19 17:51
• Resolved: 10/Sep/18 09:45

Description

It's not clear to me why we are doing this, but it looks very suspicious. Why aren't we just calling "new Random()" in these cases? (even for the tests I don't really see it - typically that would just be for repeatability)

ag "new Random[ \t]*\(" .
src/java/main/org/apache/zookeeper/ClientCnxn.java
817:        private Random r = new Random(System.nanoTime());        

src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
75:       sourceOfRandomness = new Random(System.currentTimeMillis() ^ this.hashCode());
98:        sourceOfRandomness = new Random(randomnessSeed);

src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
420:                rand = new Random(java.lang.Thread.currentThread().getId()

src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
64:    private final Random r = new Random(System.nanoTime());

src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
537:        Random r = new Random(id ^ superSecret);
554:        Random r = new Random(sessionId ^ superSecret);

src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java
271:        Random r = new Random(SESSION_ID ^ superSecret);

src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
151:            Random rand = new Random(Thread.currentThread().getId());
258:            Random rand = new Random(Thread.currentThread().getId());
288:        Random rand = new Random(Thread.currentThread().getId());

src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
40:    private Random r = new Random(1);

Issue Links

• links to: GitHub Pull Request #617