[ZOOKEEPER-1861] ConcurrentHashMap isn't used properly in QuorumCnxManager

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.0
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 11/Jan/14 23:50
• Updated: 14/Feb/14 03:03
• Resolved: 14/Feb/14 03:03

Description

queueSendMap is a ConcurrentHashMap.
At line 210:

            if (!queueSendMap.containsKey(sid)) {
                queueSendMap.put(sid, new ArrayBlockingQueue<ByteBuffer>(
                        SEND_CAPACITY));

By the time control enters if block, there may be another concurrent put with same sid to the ConcurrentHashMap.
putIfAbsent() should be used.

Similar issue occurs at line 307 as well.