Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1784

Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.5.0
    • 3.5.1
    • None
    • None
    • Committed to trunk. Thanks Raul, and sorry that it took so long to commit.

    Description

      If you look at Learner#syncWithLeader:

                  while (self.isRunning()) {
                      readPacket(qp);
                      switch(qp.getType()) {
      .......
      
                      case Leader.INFORM:
                      case Leader.INFORMANDACTIVATE:
                          PacketInFlight packet = new PacketInFlight();
                          packet.hdr = new TxnHeader();
      
                          if (qp.getType() == Leader.COMMITANDACTIVATE) {
      

      I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read "qp.getType() == Leader.INFORMANDACTIVATE".

      Assigning to Alexander for now since this is part of ZOOKEEPER-107.

      Attachments

        1. ZOOKEEPER-1784.patch
          0.8 kB
          Raúl Gutiérrez Segalés
        2. ZOOKEEPER-1784.patch
          0.8 kB
          Alexander Shraer

        Activity

          People

            rgs Raúl Gutiérrez Segalés
            rgs Raúl Gutiérrez Segalés
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: