[ZOOKEEPER-1690] Race condition when close sock may cause a NPE in sendBuffer

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.4.6
• Assignee: Unassigned
• Reporter: Jacky007
• Created: 15/Apr/13 11:53
• Updated: 15/Apr/13 11:59

Description

In NIOServerCnxn.java
public void close() {
closeSock();
...
sk.cancel();

Close sock first, then cancel the channel.

public void sendBuffer(ByteBuffer bb) {
if ((sk.interestOps() & SelectionKey.OP_WRITE) == 0) {
...
sock.write(bb);

Get ops of the channel, then read sock (may be null)

I have noticed that the 3.5.0-branch has fixed the problem.