[ZOOKEEPER-1635] ZooKeeper C client doesn't compile on 64 bit Windows

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Fix Version/s: 3.5.0

Environment

Windows x64 systems.

• Assignee: Unassigned
• Reporter: Tomas Gutierrez
• Created: 30/Jan/13 21:02
• Updated: 24/Apr/14 21:15
• Resolved: 23/Apr/14 22:02

Description

x64 target does not support _asm inline (See: http://msdn.microsoft.com/en-us/library/4ks26t93(v=vs.80).aspx)

The proposal is to use native windows function which still valid for i386 and x64 architecture.

In order to avoid any potential break, a compilation directive has been added. But, the best should be the removal of the asm part.

-----------
sample code
-----------

int32_t fetch_and_add(volatile int32_t* operand, int incr)
{
#ifndef WIN32
int32_t result;
asm _volatile_(
"lock xaddl %0,%1\n"
: "=r"(result), "=m"(*(int *)operand)
: "0"(incr)
: "memory");
return result;
#else

#ifdef WIN32_NOASM
InterlockedExchangeAdd(operand, incr);
return *operand;
#else
volatile int32_t result;
_asm

{ mov eax, operand; //eax = v; mov ebx, incr; // ebx = i; mov ecx, 0x0; // ecx = 0; lock xadd dword ptr [eax], ecx; lock xadd dword ptr [eax], ebx; mov result, ecx; // result = ebx; }

return result;*/
#endif

#endif
}