[ZOOKEEPER-111] significant cleanup of existing tests

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: tests
• Hadoop Flags: Reviewed
• Assignee: Patrick D. Hunt
• Reporter: Patrick D. Hunt
• Created: 06/Aug/08 19:08
• Updated: 12/Jun/18 04:43
• Resolved: 15/Aug/08 22:03

Description

About to submit a patch that significantly cleans up existing tests.

1) removed the need for "sleep" calls in the tests, instead I monitor the status of the server (using the client socket "stat" command) which provides a barrier to the client test operations. I use this barrier both when starting and ending the test.

2) also fixed a number of problems in the tests where the test itself was broken.

3) general cleanup and some refactoring to make it easier to write new tests, maintain old, and track down issues if the test does find a problem.

Issue Links

• blocks: ZOOKEEPER-54 remove sleeps in the tests.
• blocks: ZOOKEEPER-61 Address (remove) use of sleep(#) in client/server test cases.
• causes: ZOOKEEPER-2421 testSessionReuse is commented out
• is related to: ZOOKEEPER-86 intermittent test failure of org.apache.zookeeper.test.AsyncTest