[YETUS-995] vote table should have access to the log filename

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Precommit

Release Note

<!-- markdown -->
Users:

The log files for tests have been popped up into the voting table for many of the generated reports.

Developers:

This is a breaking change. It reworks how tests should be registering the logfiles that they present to users and how bugsystem reporting engines should retrieve the filenames for those logfiles:

* add_vote_table() has been deprecated and replaced with add_vote_table_v2() that now takes an additional parameter. Code that uses add_vote_table()/add_footer_table() combo will NOT have their log file entries reported with some bugsystem reporting engines.
* The TP_VOTE_TABLE has been re-arranged a bit to add in the log filename. Custom reporting engines will need to modified.

• Flags: Important
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 18/Sep/20 17:38
• Updated: 17/Oct/20 05:10
• Resolved: 22/Sep/20 19:20

Description

A big design from early on in test-patch history was that the log entry was separate from the vote. This setup was likely done for a variety of aesthetic and practical reasons for JIRA. However, that design is flawed in that it is letting display dictate internals. With GitHub Status (YETUS-994), this flaw is now very very obvious.

Fixing this flaw is going to be a MAJOR compatibility break with no particularly easy way to make existing code work. Details below.

Issue Links

• breaks: YETUS-998 Post vote table changes glitches
• contains: YETUS-32 Reorganize test-patch footer table
• is depended upon by: YETUS-994 Add GitHub Status as a report type