[YARN-9362] Code cleanup in TestNMLeveldbStateStoreService

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Denes Gerencser
• Reporter: Szilard Nemeth
• Created: 07/Mar/19 17:12
• Updated: 27/Nov/19 09:23
• Resolved: 26/Nov/19 20:46

Description

There are many ways to improve TestNMLeveldbStateStoreService:
1. RecoveredContainerState fields are asserted many times repeatedly. Some simple method extractions would definitely make this more readable.
2. The tests are very long and hard to read in general: Again, finding how methods could be extracted to avoid code repetition could help.
3. You name it.