[YARN-9361] Write testcase for FSLeafQueue that explicitly checks if non-zero AM-share values are not overwritten for custom resources

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: fairscheduler
• Assignee: Unassigned
• Reporter: Szilard Nemeth
• Created: 07/Mar/19 15:59
• Updated: 27/Oct/22 07:04

Description

This is a follow-up for YARN-9323, covering changes regarding explicit zero value check that has been discussed with templedf earlier.
YARN-9323 fixed a bug in FSLeafQueue#computeMaxAMResource, so that custom resource values are also set to the AM share.
We need a new test in TestFSLeafQueue that explicitly checks if the custom resource value is only being set if the fairshare for that resource is zero.
This way, we can make sure we don't overwrite any meaningful resource value.

Issue Links

• is a clone of: YARN-9360 Do not expose innards of QueueMetrics object into FSLeafQueue#computeMaxAMResource