[YARN-8990] Fix fair scheduler race condition in app submit and queue cleanup

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.2.0, 3.3.0, 3.2.3
• Component/s: fairscheduler
• Labels: pull-request-available release-blocker
• Target Version/s: 3.2.3
• Hadoop Flags: Reviewed
• Assignee: Wilfred Spiegelenburg
• Reporter: Wilfred Spiegelenburg
• Created: 08/Nov/18 10:17
• Updated: 03/Aug/21 04:12
• Resolved: 03/Aug/21 04:12

Description

With the introduction of the dynamic queue deletion in YARN-8191 a race condition was introduced that can cause a queue to be removed while an application submit is in progress.

The issue occurs in FairScheduler.addApplication() when an application is submitted to a dynamic queue which is empty or the queue does not exist yet. If during the processing of the application submit the AllocationFileLoaderService kicks of for an update the queue clean up will be run first. The application submit first creates the queue and get a reference back to the queue.
Other checks are performed and as the last action before getting ready to generate an AppAttempt the queue is updated to show the submitted application ID..

The time between the queue creation and the queue update to show the submit is long enough for the queue to be removed. The application however is lost and will never get any resources assigned.

Issue Links

• is caused by: YARN-8191 Fair scheduler: queue deletion without RM restart
• is related to: YARN-8994 Fix race condition between move app and queue cleanup in Fair Scheduler
• relates to: YARN-8992 Fair scheduler can delete a dynamic queue while an application attempt is being added to the queue
• links to: GitHub Pull Request #3254