[YARN-8528] Final states in ContainerAllocation might be modified externally causing unexpected allocation results

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1
• Component/s: capacity scheduler
• Hadoop Flags: Reviewed
• Assignee: Abandoned Account
• Reporter: Abandoned Account
• Created: 13/Jul/18 03:50
• Updated: 31/Jul/18 19:27
• Resolved: 20/Jul/18 14:49

Description

ContainerAllocation.LOCALITY_SKIPPED is final static, and its .state should always be AllocationState.LOCALITY_SKIPPED. However, this variable is public and is accidentally changed to AllocationState.APP_SKIPPED in RegularContainerAllocator under certain conditions. Once that happens, all following LOCALITY_SKIPPED situations will be treated as APP_SKIPPED.

Similar risks exist for ContainerAllocation.PRIORITY_SKIPPED/APP_SKIPPED/QUEUE_SKIPPED. 

ContainerAllocation.state should be private and should not be changed. If changes are needed, a new ContainerAllocation should be created.