[YARN-8362] Number of remaining retries are updated twice after a container failure in NM

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1
• Assignee: Chandni Singh
• Reporter: Chandni Singh
• Created: 25/May/18 00:06
• Updated: 29/May/18 21:58
• Resolved: 29/May/18 21:05

Description

The shouldRetry(int errorCode) in ContainerImpl with YARN-5015 also updated some fields in retry context- remaining retries, restart times.

This method is directly called from outside the ContainerImpl class as well- ContainerLaunch.setContainerCompletedStatus. This causes following problems:

1. remainingRetries are updated more than once after a failure. if maxRetries = 1, then a retry will not be triggered because of multiple calls to shouldRetry(int errorCode).
2. Writes to retryContext should be protected and called when the write lock is held.