[YARN-7595] Container launching code suppresses close exceptions after writes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.1, 2.8.4
• Component/s: nodemanager
• Hadoop Flags: Reviewed
• Assignee: Jim Brennan
• Reporter: Jason Darrell Lowe
• Created: 01/Dec/17 14:55
• Updated: 15/Dec/17 22:04
• Resolved: 15/Dec/17 22:04

Description

There are a number of places in code related to container launching where the following pattern is used:

  try {
    ...write to stream outStream...
  } finally {
    IOUtils.cleanupWithLogger(LOG, outStream);
  }

Unfortunately this suppresses any IOException that occurs during the close() method on outStream. If the stream is buffered or could otherwise fail to finish writing the file when trying to close then this can lead to partial/corrupted data without throwing an I/O error.