[YARN-6202] Configuration item Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.0, 3.0.0-alpha2
• Fix Version/s: 3.0.0-alpha4
• Component/s: nodemanager, resourcemanager
• Hadoop Flags: Reviewed
• Assignee: Yufei Gu
• Reporter: Yufei Gu
• Created: 16/Feb/17 00:45
• Updated: 29/Mar/21 11:01
• Resolved: 19/Apr/17 18:46

Description

Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) always be true no matter what value in configuration files. This misleads users. Two solutions:

1. Remove the configuration item and provide a method to allow exitOnDispatchException/shouldExitOnError to be false to enable related unit tests. There is no need for false value in a real daemon since daemons should crash if its dispatcher quit.
2. Make it default true instead of false, so that we don't need to hard code it to be true in RM and NM, it is still configurable, and also provide method to enable related unit tests.

Other than that, the code around it needs to refactor. public static final for a variable of interface isn't necessary, and YARN related configure item should be in class YarnConfiguration.

Issue Links

• relates to: MAPREDUCE-3634 All daemons should crash instead of hanging around when their EventHandlers get exceptions