[YARN-5714] ContainerExecutor does not order environment map

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.4.1, 2.5.2, 2.7.3, 2.6.4, 3.0.0-alpha1
• Fix Version/s: 3.1.0, 2.10.0, 3.0.4, 2.8.6, 2.9.3
• Component/s: nodemanager
• Labels: oct16-medium

Environment

all (linux and windows alike)

• Hadoop Flags: Reviewed
• Assignee: Remi Catherinot
• Reporter: Remi Catherinot
• Created: 06/Oct/16 21:06
• Updated: 14/Oct/19 15:38
• Resolved: 07/Mar/19 17:01

Description

When dumping the launch container script, environment variables are dumped based on the order internally used by the map implementation (hash based). It does not take into consideration that some env variables may refer each other, and so that some env variables must be declared before those referencing them.

In my case, I ended up having LD_LIBRARY_PATH which was depending on HADOOP_COMMON_HOME being dumped before HADOOP_COMMON_HOME. Thus it had a wrong value and so native libraries weren't loaded. Jobs were running but not at their best efficiency. This is just a use case falling into that bug, but I'm sure others may happen as well.

I already have a patch running in my production environment, i just estimate to 5 days for packaging the patch in the right fashion for JIRA + try my best to add tests.

Note: The patch is not OS aware with a default empty implementation. I will only implement the Unix version on a 1st release. I'm not used to windows env variables syntax so it will take me more time/research for it.

Issue Links

• blocks: YARN-7677 Docker image cannot set HADOOP_CONF_DIR
• duplicates: YARN-9585 Order of environment variables set up inside ContainerLaunchContext cannot be guaranteed inside the launch_container.sh resulting in inconsistent resolution of transitive environment variables