[YARN-4916] TestNMProxy.tesNMProxyRPCRetry fails.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0, 2.7.3, 2.6.4, 3.0.0-alpha1
• Fix Version/s: 2.8.0, 3.0.0-alpha1

Environment

OS X 10.11 with Oracle JDK 1.7.0_79
Windows Server 2012 with Oracle JDK 1.7.0_79

• Hadoop Flags: Reviewed
• Assignee: Tibor Kiss
• Reporter: Tibor Kiss
• Created: 02/Apr/16 19:51
• Updated: 25/Oct/19 20:26
• Resolved: 05/Apr/16 16:04

Description

The test ensures that java.net.SocketException is thrown from
NMProxy.startContainers() without the RPC Request being retried.

With Oracle JDK 1.7 on OS X & Windows BindException is thrown from startContainers().
The testcase expects that SocketException is thrown - which is BindException's superclass.
The exception type check is implemented using string compare and not reflection, therefore the thrown BindException is not accepted.

Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.149 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
testNMProxyRPCRetry(org.apache.hadoop.yarn.server.nodemanager.containermanager.TestNMProxy)  Time elapsed: 0.211 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.TestNMProxy.testNMProxyRPCRetry(TestNMProxy.java:191)

Actual exception:

2016-04-02 21:25:13,311 WARN  [Thread-93] ipc.Client (Client.java:handleConnectionFailure(880)) - Failed to connect to server: 1234/0.0.4.210:0: retries get failed due to exceeded maximum allowed retries
java.net.BindException: Can't assign requested address
        at sun.nio.ch.Net.connect0(Native Method)
        at sun.nio.ch.Net.connect(Net.java:465)
        at sun.nio.ch.Net.connect(Net.java:457)
        at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:670)
        at org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:192)
        at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:531)
        at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:495)
        at org.apache.hadoop.ipc.Client$Connection.setupConnection(Client.java:634)
        at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:733)
        at org.apache.hadoop.ipc.Client$Connection.access$2900(Client.java:378)
        at org.apache.hadoop.ipc.Client.getConnection(Client.java:1413)
        at org.apache.hadoop.ipc.Client.call(Client.java:1328)
        at org.apache.hadoop.ipc.Client.call(Client.java:1306)
        at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:230)
        at com.sun.proxy.$Proxy10.startContainers(Unknown Source)

Issue Links

• breaks: YARN-5104 TestNMProxy.testNMProxyRPCRetry failed
• is broken by: HADOOP-11212 NetUtils.wrapException to handle SocketException explicitly
• is duplicated by: YARN-4923 Test Failure TestNMProxy#testNMProxyRPCRetry
• is duplicated by: YARN-4922 TestNMProxy#testNMProxyRPCRetry fails