Calling SchemaType.isSkippedAnonymousType() can throw a NPE

• Key: XMLBEANS-260
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Wing Yew Poon
• Reporter: Luke Peters
• Component/s: XmlObject
• Affects Version/s: Version 2.1
• Fix Version/s: Version 2.4.1

Description

If isSkippedAnonymousType() is called on a SchemaType instance that does not have _outerSchemaTypeRef set, then a NPE will be thrown. Example:

  MyXmlBean myBean = MyXmlBean.Factory.newInstance();
  boolean isSkipped = myBean.schemaType().isSkippedAnonymousType(); <- throws a NPE

It seems that it should return false in this instance, rather than throw an exception. All this needs to fix is to add a null check. I'm not sure which versions exactly are effected, but it is an issue in 2.1.

Current code:

    public boolean isSkippedAnonymousType()
        { return _outerSchemaTypeRef.get().getBaseType() == this ||
                _outerSchemaTypeRef.get().getContentBasedOnType() == this; }

Potential fix:

    public boolean isSkippedAnonymousType()
        { return _outerSchemaTypeRef == null ? false : _outerSchemaTypeRef.get().getBaseType() == this ||
                _outerSchemaTypeRef.get().getContentBasedOnType() == this; }

Comments

[Wing Yew Poon]

The isSkippedAnonymousType method should only be called on a SchemaType instance that *is* in fact an anonymous type.

[Wing Yew Poon]

Fix should go into the next release (expected to be 2.5).