UrlSet excludePaths() method throws a nullpointer exception if the pathString argument is null

• Key: XBEAN-92
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Shawn Jiang
• Reporter: karan singh malhi
• Component/s: finder
• Fix Version/s: 3.6

Description

With IBM JDK 5, when we try to get the system property java.endorsed.dirs, it returns null. This is a critical issue as it prevents OpenEjb from starting

In UrlSet, the following method will lead to a NullPointerException:

public UrlSet excludeJavaEndorsedDirs() throws MalformedURLException { return excludePaths(System.getProperty("java.endorsed.dirs")); }
This is because the excludePaths() method assumes that the pathString argument is always non-null.
public UrlSet excludePaths(String pathString) throws MalformedURLException {
String[] paths = pathString.split(File.pathSeparator);
UrlSet urlSet = this;
for (String path : paths) { File file = new File(path); urlSet = urlSet.exclude(file); }
return urlSet;
}

Comments

[Shawn Jiang]

Can't recreate this anymore, that's because that

public UrlSet excludeJavaEndorsedDirs() throws MalformedURLException { return excludePaths(System.getProperty("java.endorsed.dirs")); }

has become:

public UrlSet excludeJavaEndorsedDirs() throws MalformedURLException { return excludePaths(System.getProperty("java.endorsed.dirs", "")); }

so that there will be a default "" for endorsed.dirs instead of a null. This JIRA can be closed.

[Shawn Jiang]

Seems I can't closed it. Can anyone help close this JIRA ? Thanks.

[Andreas Veithen]

I think the code is still not correct. I'm using OpenEJB 3.1.1 which depends on xbean-finder-shaded-3.6-r779512.jar. Looking at the byte code of UrlSet#excludeJavaEndorsedDirs(), this version already contains the change described above (usage of System#getProperty(String, String) instead of System#getProperty(String)). It no longer throws a NullPointerException, but excludeJavaEndorsedDirs now removes all URLs with the "file" protocol.

[David Blevins]

Andreas, if you can come up with a quick patch I can get it in. We will be cutting an xbean-finder 3.6 release in the next day or two (beginning of next week at the latest) and then an OpenEJB 3.1.2 right after.

[Andreas Veithen]

Attached a patch that corrects the behavior of excludeJavaEndorsedDirs (and excludeJavaExtDirs). If the corresponding system property is not set, then nothing will be excluded.

[David Blevins]

$ svn ci xbean-finder
Sending xbean-finder/src/main/java/org/apache/xbean/finder/UrlSet.java
Transmitting file data .
Committed revision 813275.

Didn't get this applied for the 3.6 binaries up for vote now. Unsure if we'll see a second roll.