|
Seems I can't closed it. Can anyone help close this JIRA ? Thanks.
I think the code is still not correct. I'm using OpenEJB 3.1.1 which depends on xbean-finder-shaded-3.6-r779512.jar. Looking at the byte code of UrlSet#excludeJavaEndorsedDirs(), this version already contains the change described above (usage of System#getProperty(String, String) instead of System#getProperty(String)). It no longer throws a NullPointerException, but excludeJavaEndorsedDirs now removes all URLs with the "file" protocol.
Andreas, if you can come up with a quick patch I can get it in. We will be cutting an xbean-finder 3.6 release in the next day or two (beginning of next week at the latest) and then an OpenEJB 3.1.2 right after.
Attached a patch that corrects the behavior of excludeJavaEndorsedDirs (and excludeJavaExtDirs). If the corresponding system property is not set, then nothing will be excluded.
$ svn ci xbean-finder
Sending xbean-finder/src/main/java/org/apache/xbean/finder/UrlSet.java Transmitting file data . Committed revision 813275. Didn't get this applied for the 3.6 binaries up for vote now. Unsure if we'll see a second roll. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
public UrlSet excludeJavaEndorsedDirs() throws MalformedURLException { return excludePaths(System.getProperty("java.endorsed.dirs")); }
has become:
public UrlSet excludeJavaEndorsedDirs() throws MalformedURLException { return excludePaths(System.getProperty("java.endorsed.dirs", "")); }
so that there will be a default "" for endorsed.dirs instead of a null. This JIRA can be closed.