org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces

• Key: XBEAN-109
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Ivan
• Reporter: Ingo Bormann
• Component/s: classloader
• Fix Version/s: 3.6

Description

A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead.

I have a patched version where this is fixed for the full package org.apache.xbean.classloader.

Comments

[Ingo Bormann]

This is a diff between the head of SVN and my modified version. You will find that File.toURL() is replaced by File.toURI().toURL() in a couple of places. Should not be too hard to apply.

[Benjamin Bentmann]

+1 on the usage of File.toURI().toURL()

As for the replacement of new File(url.getPath()) with new File(url.toURI()): It might be wise to simply move the call new File(url.getPath()) into the catch for the URISyntaxException. This would increase robustness for the case where the input URL is not properly escaped.

Merge the patch to XBean trunk at rev 776705. Thanks Ingo Bormann for the patch !

[Ivan]

Hi, just find that for XBean JIRAs, there is no "resolve" action. So for these JIRAs, shall I need to start a RTC view, then commit the patch files ?

[David Jencks]

I think we are just closing issues once they are fixed. Ideally we would make the jira options the same as the geronimo ones.