Does not build under J2SE 1.5

• Key: XALANJ-2147
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Trivial
• Assignee: Sarah McNamara
• Reporter: Scott Lamb
• Component/s: Xalan
• Affects Version/s: 2.7.1
• Fix Version/s: 2.7

Description

ant gives the following error when building Xalan:

    [javac] javac: target release 1.1 conflicts with default source release 1.5

This is easy to fix by specifying the source version in the build.xml.

Comments

[Scott Lamb]

Fix

[Sarah McNamara]

Although the existing patch will work, I think we should remove the use of target and source from the javac directives for the following reasons:

- not all javac directives in Xalan Java's build.xml file make use of the "target" setting, so having 3 that make use of it and others that don't seems inconsistent to me
- if, down the road, the values of target="1.1" and source="1.2" become obsolete, we will have to continue to maintain the proper settings

[Sarah McNamara]

I'm attaching a new patch that removes target="1.1" from the javac directives.

[Scott Lamb]

I'm not sure the results of the other javac are actually the final product; they look like code generators, samples, etc.

Regardless, I don't care. If everything specified source="1.4" target="1.4" and older JREs didn't work, I'd be just as happy. (Actually happier, because target="1.1" means there must be a lot of pre-collections code that could then be ripped out.) But I tend to find that difficult to sell to large OSS projects.

[Brian Minchau]

Assigned to Sarah M., per the JIRA meeting July 12, 2005.

[Brian Minchau]

Set reviewer of patch to Henry Z., per JIRA meeting July 12, 2005.

We should go with Sarah's newer patch.

[Henry Zongaro]

I have reviewed Sarah's patch [1] and believe that it correctly resolves the problem. Note: I think Sarah already inadvertently applied this change as part of her omnibus patch under XALANJ-2170.

[1] http://issues.apache.org/jira/secure/attachment/12311031/XALANJ-2147.newpatch

[Sarah McNamara]

Oops, Henry, you're right, I did commit the fix to this defect as part of my XALANJ-2170 patch. Need to be careful about that next time.

Guess I can now mark this one as fixed.

[Brian Minchau]

Scott,
as the reporter of the issue, and since the fix is in the Xalan-J 2.7 release, please confirm the fix so that we can close this issue.

It's definitely fixed. Thanks!

(Are you asking me to change the status to verified? Either I don't have permissions to do that or I don't know how to use JIRA. Probably both.)