Add the component name to the Schema-1066 assertion method

• Key: WODEN-3
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Dan Harvey
• Reporter: John Kaputin
• Component/s: Validation
• Fix Version/s: M8

Description

The message for Schema-0016 assertion just reports the namespace URI in error. It might be more useful to report the name of the schema component as well. This could be achieved by specifying two message parameters (local name and namespace URI) and changing the testAssertionSchema0016 method in the validator to accept a QName argument rather than a namespace string. The message could then be formatted with the element or type's local name as well as its namespace URI.

Comments

[Sriram Rao]

As described in the relevant JIRA, I have modified testAssertionSchema0016 method to accept a QName instead of a namespaceURI. Within the method, I get the NameSpaceURI and the localpart from the QName supplied. The reportError will then use both the namespace and the localpart to log an error.

The error message has been modified to
"Schema-0016 = The component ''{1}'' refers to the XML Schema namespace ''{0}''. But this namespace is not available. In order to reference components from a XML Schema namespace the namespace must be imported or defined inline."

with the {1} referring to the local part and {0} referring to the namespace.

I have also modified the 2 calls to this testAssertionSchema0016 method to send QName instead of the namespaceURI.

This has not been tested this against any WSDL or a JUnit test case. I have attached the modified Class WSDLDocumentValidator and the Messages.properties files with this email.

[Sriram Rao]

John:

Attached are the patch files for the 3 code components that were changed:
Message.properties
WSDLDocumentValidator.java
WSDLDocumentValidatorTest.java

Sriram

[John Kaputin]

r541655
Assertion Schema-0016 has been removed from the WSDL2 spec, so this JIRA can be cancelled. For now, I have modified Woden by commenting out the calls for testing Schema-0016. The whole Validator and ValidatorTest code is to be re-implemented soon when a new plugin/extension mechanism is available for validation.

[Arthur Ryman]

John,

All the assertions were renamed as part of the WSDL 2.0 PR spec publication.

[Arthur Ryman]

I send an email that described the rename script. [1]

[1] http://mail-archives.apache.org/mod_mbox/ws-woden-dev/200705.mbox/[e-mail]%3e

[Arthur Ryman]

The new number for this assertion is Schema-1066.

John - I can do a batch rename using the script. Shall I do this?

[John Kaputin]

Patch of the Messages.properties file with the new message required for assertion Schema-1066

[John Kaputin]

I used Arthur's batch script to renumber the existing WSDL assertions (WODEN-149). The classes WSDLDocumentValidator and WSDLDocumentValidatorTest must be modified to support the new message format for assertion Schema-1066 (see latest patch file for Messages.properties for new msg format). I'll ask Dan Harvey to have a go at this.

[John Kaputin]

Fix supplied by Dan Harvey.

[John Kaputin]

Dan's fix is in the file patch-item-3.txt

[John Kaputin]

Fix supplied by Dan, assigning JIRA to him.

[John Kaputin]

Changed JIRA title from Schema-0016 to Schema-1066

[John Kaputin]

r563107