Remove QNameUtils class

• Key: WODEN-171
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Dan Harvey
• Reporter: John Kaputin
• Fix Version/s: M8

Description

The QNameUtils class is not necessary and removing it will help with WODEN-67 to modularize the Woden build create DOM and OM specific binary jars. This class has one method 'matches()' which compares a specified QName to the QName of a specified element object. It contains a hardcoded conditional switch to check the element object type and then forwards to DOMQNameUtils.matches() or OMQNameUtils.matches(). Not very O/O!

This method is only used in 2 places and can be easily replaced by using the QName.equals() method of directly. By eliminating this class and its dual compile dependency on DOM and OM, we can modularize the Maven build to support WODEN-67.

Comments

[John Kaputin]

The 2 places this class is used are SOAPModuleDeserializer and SOAPHeaderBlockDeserializer.

Need to change:
if (QNameUtils.matches(Constants.Q_ELEM_DOCUMENTATION, tempEl)

to:
if(Constants.Q_ELEM_DOCUMENTATION.equals(tempEl.getQName()))

[John Kaputin]

Thanks to Dan Harvey for contributing a fix in file patch-item-171.txt

[John Kaputin]

Dan contributed the fix, so assigning JIRA to him.

[John Kaputin]

r563109